[Concurrency] Infer nonisolated for a mutable storage of a value type accessed from within the module.
#72473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simanerush
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test macOS |
hborla
approved these changes
Mar 21, 2024
…pe accessed from within the module.
…an experimental feature flag.
simanerush
force-pushed
the
nonisolated-property-struct-inference
branch
from
dffe45d to
05859b4
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mutable storage of a globally-isolated value type is data-race safe because it is copied every time it crosses an isolation boundary.
Thus, treat such storage as
nonisolatedwhen accessed from within the module.I have removed redundant errors from the tests that access such properties, and it seems like the
derived_conformances_nonisolated.swifttest becomes the primary test for this PR.I am not fully convinced that removing errors from
global_actor_inference.swiftis right, so I would appreciate feedback on that!This PR is the first part of the implementation of this pitch