Some improvements for inline bitfields in SILNode, SILBasicBlock and Operand #72485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In contrast to `assert` and similar functions, `require` works in no-assert builds the same way as in debug builds. It can be used to check invariants also in release builds.
… functions This fixes a bug with can cause OperandSet to misbehave for instructions which were moved from another function.
* Let the customBits and lastInitializedBitfieldID share a single uint64_t. This increases the number of available bits in SILNode and Operand from 8 to 20. Also, it simplifies the Operand class because no PointerIntPairs are used anymore to store the operand pointer fields. * Instead make the "deleted" flag a separate bool field in SILNode (instead of encoding it with the sign of lastInitializedBitfieldID). Another simplification * Enable important invariant checks also in release builds by using `require` instead of `assert`. Not catching such errors in release builds would be a disaster. * Let the Swift optimization passes use all the available bits and not only a fixed amount of 8 (SILNode) and 16 (SILBasicBlock).
Implemented by bridging the C++ OperandSet, similar to BasicBlockSet and NodeSet
|
@swift-ci test |
|
Thanks! |
gottesmm
reviewed
Apr 3, 2024
| /// Checks the `condition` and if it's false abort with `message`. | ||
| /// In contrast to `assert` and similar functions, `require` works in | ||
| /// no-assert builds the same way as in debug builds. | ||
| inline void require(bool condition, const char *message) { |
There was a problem hiding this comment.
@eeckstein Shouldn't this be in the llvm or swift namespace rather than the global namespace
There was a problem hiding this comment.
yes, that makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear operand bit fields of instructions which are moved between functions. This fixes a bug with can cause
OperandSetto misbehave for instructions which were moved from another function.Let the
customBitsandlastInitializedBitfieldIDshare a singleuint64_t. This increases the number of available bits inSILNodeandOperandfrom 8 to 20 without increasing the size of those data types. Also, it simplifies theOperandclass because noPointerIntPairs are used anymore to store the operand pointer fields.Instead make the "deleted" flag a separate bool field in
SILNode(instead of encoding it with the sign oflastInitializedBitfieldID) - another simplification.Enable important invariant checks also in release builds by using
requireinstead ofassert. Not catching such errors in release builds would be a disaster.Let the Swift optimization passes use all the available bits and not only a fixed amount of 8 (
SILNode) and 16 (SILBasicBlock).Add
OperandSetandOperandWorklistin SwiftCompilerSources