[6.0] Fix SILCombine of inject_enum_addr to correctly check for unreferenceable storage #72489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elds have unreferenceable storage
|
@swift-ci test |
tbkka
approved these changes
Mar 21, 2024
|
@swift-ci test linux platform |
|
@swift-ci test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We can't create struct values if they have unreferenceable storage. Previously
hasUnreferenceableStoragewas used to determine if the StructDecl had unreferenceable storage. This isn't sufficient because the api doesn't look in nested structs. Added a new api calledfindUnreferenceableStorageand use it insteadScope: Effects optionals of empty types that may have nested unreferenceable storage
Issue: rdar://125125245
Original PR: #72479
Risk: Low.
Testing: Swift CI
Reviewer: @atrick @nate-chandler