[Tests] NFC: Add a couple of tests for parametrized opaque result types #72493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
approved these changes
Mar 21, 2024
|
|
||
| func test1() -> some P3<Int> { // expected-note {{opaque return type declared here}} | ||
| return G<S>() | ||
| // expected-error@-1 {{type of local function 'test1()' requires that 'S' conform to 'Int'}} |
There was a problem hiding this comment.
do you want to fix the diagnostic to take requirement kind into account too? :) It seems it was hardcoded to RequirementKind::Conformance
There was a problem hiding this comment.
Yeah, I'll look into that!
|
I'll follow-up with a same-type diagnostic improvement today. |
xedin
added a commit
to xedin/swift
that referenced
this pull request
Mar 25, 2024
… opaque return type Follow-up to swiftlang#72493
xedin
added a commit
to xedin/swift
that referenced
this pull request
Mar 26, 2024
… opaque return type Follow-up to swiftlang#72493
xedin
added a commit
to xedin/swift
that referenced
this pull request
Mar 27, 2024
… opaque return type Follow-up to swiftlang#72493 (cherry picked from commit 08e9382)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.