AST: Remove ProtocolDecl::getSuperclass() #72495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ProtocolDecl::getSuperclass() Protocols with a superclass bound written as `protocol P where Self: C` return null from getSuperclass(). Unqualified lookup only cares about getSuperclassDecl(), so serialize that instead. Fixes rdar://problem/124478687.
…ete contraction
This changes the minimized signature in a very narrow edge case.
If you have
class C : P {}
and also
protocol P : C {}
protocol P where Self : C {}
then <T where T : P, T : C> now becomes <T : P> both with spellings;
before, the first one gave <T : P> and the second <T : C>.
The condition that the conforming type satisfies the superclass bound of the conformed protocol is already covered by the conformance constraint itself.
slavapestov
force-pushed
the
fix-protocol-superclass
branch
from
96414be to
1a7bdb4
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
xedin
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up my own technical debt from 2018.
There are two ways to spell a class-constrained protocol:
The
ProtocolDecl::getSuperclass()method only handled the first case, returning a null Type in the second case.This remained an issue for as long as it did because most clients would either use the lower-level
getSuperclassDecl(), which correctly visited the where clause, or they would process requirement signature requirements or whatever.This problem surfaced again because there was a recent regression with the
where Self: Cform because a new call to getSuperclass() was introduced in serialization.Also it turns out all existing other callers of
getSuperclass()either suffered from the same problem, or were unnecessary. So this PR just removesProtocolDecl::getSuperclass().Fixes rdar://problem/124478687.