Skip to content

Fix the fixits for dispatch_async and dispatch_group_async #7254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2017
Merged

Fix the fixits for dispatch_async and dispatch_group_async #7254

merged 1 commit into from
Feb 6, 2017

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Feb 5, 2017 •
edited by AnthonyLatsis
Loading

They erroneously suggested DispatchQueue.asynchronously, but it's actually DispatchQueue.async. This is #6958 cherry-picked for Swift 3.1.

Resolves swiftlang/swift-corelibs-libdispatch#699.

@NachoSoto
Fix the fixits for dispatch_async and dispatch_group_async
f107ce7 
They erroneously suggested `DispatchQueue.asynchronously`, but it's actually `DispatchQueue.async`.
@jtbandes
Copy link
Contributor

jtbandes commented Feb 5, 2017

Since this is a release branch, the PR should include this additional info: https://swift.org/blog/swift-3-1-release-process/#pull-requests-for-release-branch

@NachoSoto
Copy link
Contributor Author

Sorry but I don't have time for that, I just did what I was asked for in that SR. If somebody wants to fill in those details that'd be great.

@DougGregor
Copy link
Member

  • Explanation: The Fix-Its for dispatch_async and dispatch_group_async use pre-final-Swift-3 names (asychronously) rather than the final Swift 3 names (async).

  • Scope: Affects Swift 2 code using Dispatch that is compiled as Swift 3.

SR Issue: SR-3856

Risk: Zero. This only affects the "renamed" message in the Dispatch overlay.

Testing: Normal compiler regression tests.

DougGregor
DougGregor approved these changes Feb 6, 2017
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor DougGregor added this to the Swift 3.1 milestone Feb 6, 2017
@swift-ci
Copy link
Contributor

swift-ci commented Feb 6, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - f107ce7
Test requested by - @DougGregor

@tkremenek
Copy link
Member

@swift-ci clean test macOS

@tkremenek tkremenek merged commit 923a137 into swiftlang:swift-3.1-branch Feb 6, 2017
@NachoSoto NachoSoto deleted the dispatch-async-fixit branch February 6, 2017 20:49
@NachoSoto NachoSoto mentioned this pull request Feb 5, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees

@tkremenek tkremenek

@ematejska ematejska

Labels
None yet
Projects
None yet
Milestone
Swift 3.1
Development

Successfully merging this pull request may close these issues.
6 participants
@NachoSoto @jtbandes @DougGregor @swift-ci @tkremenek @ematejska