[unittests] Enable debug info when compiling unittests when debug info is enabled. #72548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
etcwilde
reviewed
Mar 24, 2024
There was a problem hiding this comment.
Can you grab a trace with --trace-expand? CMake should know how to set this. It'll be set up with CMAKE_<LANG>_FLAGS_DEBUG_INIT and CMAKE_<LANG>_FLAGS_RELWITHDEBINFO_INIT. Which target is this failing with and is it on all languages in that target, or is it specific to a given language?
|
@etcwilde I don't know why this is happening TBH. I imagine it has something to do with how LLVM sets up its unit tests. I just hit it. |
…o is enabled. I noticed this while I was debugging a failure in unittest.
gottesmm
force-pushed
the
pr-9ea3226d4ec4e1094426a535db22d95597f96990
branch
from
e1e5e6c to
a114a30
Compare
|
@swift-ci smoke test |
|
Evan and I spoke offline, he is fine with the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while I was debugging a failure in unittest.