[Associated type inference] Resolve @_implements on AsyncSequence.Failure
#72552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
…ailure A source-compatibility hack to not resolve AsyncSequence.Failure via lookup accidentally disabled the `@_implements`-based lookup that we use to avoid having to run inference again in Swift textual interfaces. Tweak the logic here to narrow the source-compatibilty hack. Fixes rdar://125320522.
DougGregor
force-pushed
the
implements-on-asyncsequence-failure-6.0
branch
from
4744a30 to
78430e0
Compare
|
@swift-ci please test |
|
@swift-ci please test |
hborla
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_implements-based lookup that we use to avoid having to run inference again in Swift textual interfaces. Tweak the logic here to narrow the source-compatibility hack, so we don't need to run inference again when (e.g.) building Swift interfaces.@_implementson type witnesses and use it for async sequenceFailure#72234@_implementson AsyncSequence.Failure #72551AsyncSequence.Failure's interaction with associated type inference.@_implements-based associated type witness lookup.