[6.0 cherry-pick] [embedded] Compile-time (literal) KeyPaths for Embedded Swift #72562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kubamracek
commented
Mar 25, 2024
kubamracek
commented
- Explanation: Enable KeyPath/AnyKeyPath/PartialKeyPath/WritableKeyPath in Embedded Swift, but for compile-time use only. Details at [embedded] Compile-time (literal) KeyPaths for Embedded Swift #72472.
- Scope: Enabling the keypath constant-folding optimization to kick in in more cases, Embedded Swift compilations in particular.
- Risk: Low. Stdlib changes are limited to Embedded Swift only. Compiler changes limited to keypath constant-folding optimization.
- Testing: Added test case.
- Issue: rdar://125363334
- Reviewer: @eeckstein, @Azoy, @phausler on [embedded] Compile-time (literal) KeyPaths for Embedded Swift #72472
Enable KeyPath/AnyKeyPath/PartialKeyPath/WritableKeyPath in Embedded Swift, but for compile-time use only: - Add keypath optimizations into the mandatory optimizations pipeline - Allow keypath optimizations to look through begin_borrow, to make them work even in OSSA. - If a use of a KeyPath doesn't optimize away, diagnose in PerformanceDiagnostics - Make UnsafePointer.pointer(to:) transparent to allow the keypath optimization to happen in the callers of UnsafePointer.pointer(to:).
…nstructions for keypath operands
…retains to prevent keypath instructions from being optimized out
DougGregor
approved these changes
Mar 25, 2024
|
@swift-ci please test |
|
@swift-ci please test Linux platform |
1 similar comment
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.