[region-isolation] Shrink PartitionUtils.h by moving large functions to cpp file. #72572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to cpp file. Just making PartitionUtils.h a little easier to walk through by moving more of the impl into the .cpp file. This reduces the header from ~1500 lines to ~950 lines which is more managable. This is especially important since I am going to be adding IsolationHistory to the header file which will expand it even further.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making PartitionUtils.h a little easier to walk through by moving more of the impl into the .cpp file. This reduces the header from ~1500 lines to ~950 lines which is more managable. This is especially important since I am going to be adding IsolationHistory to the header file which will expand it even further.
I am upstreaming this now since I found that this helped me with IsolationHistory (and my branch is based on it), but I need to fix other bugs that are going to also touch this same code, so it makes sense to just upstream the NFC work to prevent rebase issues.