Skip to content

[6.0] SIL: fix runtime effect of copy_addr of trivial types #72581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

[6.0] SIL: fix runtime effect of copy_addr of trivial types #72581

merged 1 commit into from
Mar 27, 2024

Conversation

eeckstein
Copy link
Contributor

  • Explanation: Fixes a false performance error when using large structs in performance-annotated functions, e.g. @_noLocks. It is caused by a wrong runtime effect definition for the copy_addr SIL instruction.
  • Scope: Only affects performance annotations
  • Risk: Low. The change only has an impact on performance-annotation related diagnostics
  • Testing: Added test case.
  • Issue: rdar://125397495
  • Reviewer: @kubamracek
  • Main branch PR: SIL: fix runtime effect of copy_addr of trivial types #72389

@eeckstein eeckstein requested a review from kubamracek March 26, 2024 06:12
@eeckstein eeckstein requested a review from a team as a code owner March 26, 2024 06:12
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein
Copy link
Contributor Author

@swift-ci test linux

@eeckstein eeckstein changed the title SIL: fix runtime effect of copy_addr of trivial types [6.0] SIL: fix runtime effect of copy_addr of trivial types Mar 26, 2024
@eeckstein
Copy link
Contributor Author

@swift-ci test linux

@eeckstein eeckstein merged commit 67fd13f into swiftlang:release/6.0 Mar 27, 2024
@eeckstein eeckstein deleted the copy-addr-effect-6.0 branch March 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubamracek kubamracek kubamracek approved these changes

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eeckstein @kubamracek @tbkka