Skip to content

[AST] Change some builtins to conform their result to Escapable #72594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[AST] Change some builtins to conform their result to Escapable #72594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions lib/AST/Builtins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,14 +862,16 @@ static ValueDecl *getRefCountingOperation(ASTContext &ctx, Identifier id) {
static ValueDecl *getLoadOperation(ASTContext &ctx, Identifier id) {
return getBuiltinFunction(ctx, id, _thin,
_generics(_unrestricted,
_conformsTo(_typeparam(0), _copyable)),
_conformsTo(_typeparam(0), _copyable),
_conformsTo(_typeparam(0), _escapable)),
_parameters(_rawPointer),
_typeparam(0));
}

static ValueDecl *getTakeOperation(ASTContext &ctx, Identifier id) {
return getBuiltinFunction(ctx, id, _thin,
_generics(_unrestricted),
_generics(_unrestricted,
_conformsTo(_typeparam(0), _escapable)),
_parameters(_rawPointer),
_typeparam(0));
}
Expand Down Expand Up @@ -902,7 +904,8 @@ static ValueDecl *getDestroyArrayOperation(ASTContext &ctx, Identifier id) {
static ValueDecl *getCopyOperation(ASTContext &ctx, Identifier id) {
return getBuiltinFunction(ctx, id, _thin,
_generics(_unrestricted,
_conformsTo(_typeparam(0), _copyable)),
_conformsTo(_typeparam(0), _copyable),
_conformsTo(_typeparam(0), _escapable)),
_parameters(_typeparam(0)), _typeparam(0));
}

Expand Down Expand Up @@ -976,12 +979,16 @@ static ValueDecl *getAllocWithTailElemsOperation(ASTContext &Context,
1 + NumTailTypes > (int)std::size(GenericParamNames))
return nullptr;
BuiltinFunctionBuilder builder(Context, 1 + NumTailTypes);
builder.addParameter(makeMetatype(makeGenericParam(0)));

auto resultTy = makeGenericParam(0);
builder.addConformanceRequirement(resultTy, KnownProtocolKind::Escapable);

builder.addParameter(makeMetatype(resultTy));
for (int Idx = 0; Idx < NumTailTypes; ++Idx) {
builder.addParameter(makeConcrete(BuiltinIntegerType::getWordType(Context)));
builder.addParameter(makeMetatype(makeGenericParam(Idx + 1)));
}
builder.setResult(makeGenericParam(0));
builder.setResult(resultTy);
return builder.build(Id);
}

Expand Down Expand Up @@ -1262,6 +1269,7 @@ static ValueDecl *getCOWBufferForReading(ASTContext &C, Identifier Id) {
//
BuiltinFunctionBuilder builder(C, 1, true);
auto T = makeGenericParam();
builder.addConformanceRequirement(T, KnownProtocolKind::Escapable);
builder.addParameter(T);
builder.setResult(T);
return builder.build(Id);
Expand All @@ -1286,7 +1294,11 @@ static ValueDecl *getCastReferenceOperation(ASTContext &ctx,
// SILGen and IRGen check additional constraints during lowering.
BuiltinFunctionBuilder builder(ctx, 2);
builder.addParameter(makeGenericParam(0), ParamSpecifier::LegacyOwned);
builder.setResult(makeGenericParam(1));

auto resultTy = makeGenericParam(1);
builder.addConformanceRequirement(resultTy, KnownProtocolKind::Escapable);
builder.setResult(resultTy);

return builder.build(name);
}

Expand All @@ -1296,7 +1308,11 @@ static ValueDecl *getReinterpretCastOperation(ASTContext &ctx,
// SILGen and IRGen check additional constraints during lowering.
BuiltinFunctionBuilder builder(ctx, 2);
builder.addParameter(makeGenericParam(0), ParamSpecifier::LegacyOwned);
builder.setResult(makeGenericParam(1));

auto resultTy = makeGenericParam(1);
builder.addConformanceRequirement(resultTy, KnownProtocolKind::Escapable);
builder.setResult(resultTy);

return builder.build(name);
}

Expand Down Expand Up @@ -1485,7 +1501,11 @@ static ValueDecl *getConvertUnownedUnsafeToGuaranteed(ASTContext &ctx,
BuiltinFunctionBuilder builder(ctx, 3);
builder.addParameter(makeGenericParam(0)); // Base
builder.addParameter(makeGenericParam(1), ParamSpecifier::InOut); // Unmanaged
builder.setResult(makeGenericParam(2)); // Guaranteed Result

auto resultTy = makeGenericParam(2);
builder.addConformanceRequirement(resultTy, KnownProtocolKind::Escapable);
builder.setResult(resultTy); // Guaranteed Result

return builder.build(id);
}

Expand Down