Skip to content

[LifetimeCompletion] Handle endAsyncLetLifetime. #72598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Mar 26, 2024

Handle it like an end_borrow.

@nate-chandler nate-chandler force-pushed the lifetime-completion/20240326/1 branch from c29de2c to 52a1f4d Compare March 27, 2024 14:01
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be better to have instructions for these things given the special ownership handling, stack nesting etc. I don't know when the right time to fix that will be.

@nate-chandler nate-chandler marked this pull request as ready for review March 27, 2024 19:36
@nate-chandler nate-chandler merged commit a8e6a47 into swiftlang:main Mar 27, 2024
@nate-chandler nate-chandler deleted the lifetime-completion/20240326/1 branch March 27, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants