[concurrency] Diagnose synchronous sendable actor isolated functions that have their actor isolation type erased. #72605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that have their actor isolation type erased. The problem that we are running into here is that: 1. actor isolated functions are considered sendable... so we cannot use region based isolation here. 2. But, structurally a synchronous actor isolated function can only be called from a context where we know that it is actor isolated so the caller can hop to the correct executor. Once the value is type erased and passed to a caller, we no longer have that information potentially creating races. Since I can't use region isolation here, I created a type checker check instead. rdar://118206647
gottesmm
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci smoke test |
|
I believe this is subsumed by #72607 unless we want to repurpose this PR for the region isolation issue mentioned in that PR description |
|
No. I am just going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem that we are running into here is that:
actor isolated functions are considered sendable... so we cannot use region based isolation here.
But, structurally a synchronous actor isolated function can only be called from a context where we know that it is actor isolated so the caller can hop to the correct executor. Once the value is type erased and passed to a caller, we no longer have that information potentially creating races.
Since I can't use region isolation here, I created a type checker check instead.
rdar://118206647