[Concurrency] Downgrade reportUnexpectedExecutor to error on old SDKs by default #72610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
added
the
concurrency
…eckIsolated_bincompat.swift
|
@swift-ci please smoke test |
|
Will move this into the #71172 instead because they overlap quite a bit -- can't do checkIsolated without similar checks either as it would crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be more careful when upgrading the executor check to "default mode is crashing", and should only do so in the upcoming release.
This adds a runtime check that we'll replace with checking what version of the SDKs an app was linked against. If it is the release with Swift 6 (future), we'll make it crash by default, but by doing it dynamically like this -- old apps, linked against ols SDKs will be allowed to keep working, until they rebuild with a new SDK and get the new behavior.
This semi-undoes the flag swap from: 8787846
And prepares the "hook" we'll have to implement once the the releases are announced in the future.
Resolves rdar://125107864