[6.0][Macros] Remove plugin related flags from toolchain Info.plist #72642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-external-plugin-path` flags pointing XcodeDefault.xctoolchain were needed to use macro plugins in Apple SDK. But since Apple macro plugins are not in `.xctoolchain` anymore, these flags are useless. rdar://125498074 (cherry picked from commit 5d48a5a)
rintaro
changed the title
|
@swift-ci Please test |
owenv
approved these changes
Mar 28, 2024
bnbarham
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #72629 into
relaese/6.0-external-plugin-pathflags pointingXcodeDefault.xctoolchain. That was needed to use macro plugins in Apple SDK. But since Apple macro plugins are now in platform directories, this is not needed anymore. Also it was actively harmful because these options precede project'sOTHER_SWIFT_FLAGS, which makes it difficult to override.