Skip to content

[cxx-interop] serialize x-refs for class template specializations #72643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2024
Merged

[cxx-interop] serialize x-refs for class template specializations #72643

merged 1 commit into from
Apr 1, 2024
+157 −14

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Mar 28, 2024 •
edited
Loading

Working on testing/validation

@hyp hyp force-pushed the eng/cxx-interop/xrefcts branch from 5875f9c to b522a4b Compare March 28, 2024 00:13
@hyp
Copy link
Contributor Author

hyp commented Mar 28, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 28, 2024

Fix for
#70253

@hyp hyp force-pushed the eng/cxx-interop/xrefcts branch from b522a4b to 6e7f1ec Compare March 28, 2024 23:36
@hyp hyp marked this pull request as ready for review March 28, 2024 23:36
@hyp hyp requested review from zoecarver and egorzhdan as code owners March 28, 2024 23:36
@hyp hyp requested review from compnerd and hjyamauchi March 28, 2024 23:36
@hyp
Copy link
Contributor Author

hyp commented Mar 28, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 28, 2024

@swift-ci please test source compatibility

@hyp hyp linked an issue Mar 28, 2024 that may be closed by this pull request
Deserialization failure (XRefError) compiler crashes where certain std::vector related instantiated types are not found with C++ interop #70253
Closed
@hyp hyp force-pushed the eng/cxx-interop/xrefcts branch from 6e7f1ec to 7e32c7d Compare March 29, 2024 01:53
@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test source compatibility

@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test macOS platform

compnerd
compnerd approved these changes Mar 29, 2024
View reviewed changes
egorzhdan
egorzhdan reviewed Mar 29, 2024
View reviewed changes
@hyp hyp force-pushed the eng/cxx-interop/xrefcts branch from 7e32c7d to 0c7b1ce Compare March 29, 2024 17:10
@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test

@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test source compatibility

@hyp hyp mentioned this pull request Mar 29, 2024
Closed
13 tasks
@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test linux platform

@hyp
Copy link
Contributor Author

hyp commented Mar 29, 2024

@swift-ci please test

@hyp hyp merged commit bdc3717 into swiftlang:main Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan left review comments

@compnerd compnerd compnerd approved these changes

@hjyamauchi hjyamauchi hjyamauchi approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deserialization failure (XRefError) compiler crashes where certain std::vector related instantiated types are not found with C++ interop
4 participants
@hyp @compnerd @egorzhdan @hjyamauchi