[Demangler] Fix assertion failure. #72653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's illegal to call `node->addChild()` with a `NULL` child argument; it's possible to construct unexpected `Node` trees by passing invalid manglings, and in this case that was causing `popTypeAndGetChild()` to fail (because the top node was not a `Type` node), which then meant that the call to `addChild` had a `NULL` child argument. The simplest fix is to use `createWithChildren()` to do the node construction, because that function checks its arguments for `NULL`s. rdar://125350219
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's illegal to call
node->addChild()with aNULLchild argument; it's possible to construct unexpectedNodetrees by passing invalid manglings, and in this case that was causingpopTypeAndGetChild()to fail (because the top node was not aTypenode), which then meant that the call toaddChildhad aNULLchild argument.The simplest fix is to use
createWithChildren()to do the node construction, because that function checks its arguments forNULLs.rdar://125350219