[6.0] [DebugInfo] Salvage debug info for stores removed by DeadObject-Elim #72664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
Mar 28, 2024
Snowy1803
commented
- Explanation:Debug info was lost by the Dead Object Elimination pass. This PR salvages the debug info for the eliminated object.
- Scope: Adds debug value instructions in the Dead Object Elimination pass
- Original PR: [DebugInfo] Salvage debug info for stores removed by DeadObjectElim #72207
- Risk: Low, only debug instructions are added
- Testing: The SILVerifier check ensures all debug info is correct. A test has also been added for this.
- Issue: rdar://124283055
- Reviewer: @adrian-prantl
rdar://124283055 (cherry picked from commit 4c8beef)
|
@swift-ci test |
adrian-prantl
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.