[6.0] LargeTypesReg2Mem: Add a heuristic for C character arrays #72708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can lower to a set of i64 registers we consider small but exploded to (manifested as SSA) registers they will cause significant code bloat. rdar://125265576 Issue: Improve heuristic of large types handling Risk: Low-Medium. Change to a heuristic Testing: Tested as part of CI testing Reviewer: @eeckstein Cherry-pick from pull/72694
|
@swift-ci test |
airspeedswift
approved these changes
Apr 2, 2024
aschwaighofer
added a commit
that referenced
this pull request
May 14, 2024
[6.0] Revert "Merge pull request #72708 from aschwaighofer/c_array_heuristic_6.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can lower to a set of i64 registers we consider small but exploded to (manifested as SSA) registers they will cause significant code bloat.
rdar://125265576
Issue: Improve heuristic of large types handling
Risk: Low-Medium. Change to a heuristic
Testing: Tested as part of CI testing
Reviewer: @eeckstein
Cherry-pick from #72694