[6.0][TypeChecker] InferSendableFromCaptures: Infer @Sendable on adjusted types #72741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e `FunctionType` This method is always called after the type is opened by the solver which means that we never end up with `GenericFunctionType`. (cherry picked from commit eb97553)
…adjustFunctionTypeForConcurrency` (cherry picked from commit 48e9684)
…nversions None of the diagnostics in MiscDiagnostics make a distinction between sendable or actor-isolated function references which means that we can skip conversions while reaching for a declaration used in an application. (cherry picked from commit 64a200a)
…bers to `adjustFunctionTypeForConcurrency` (cherry picked from commit a7f9a68)
(cherry picked from commit d6f57c9)
|
@swift-ci please test |
hborla
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #72527
Explanation:
Previously sendability was inferred directly on an (opened) interface type and
carried over to the "adjusted" type, this creates a problem for some partially
applied references to isolated members because they have to be wrapped in an
autoclosure that would attempt a conversion from i.e.
@Sendableto@MainActortype and be diagnosed an a concurrency issue.
Instead of doing that let's apply inference to the adjusted type, which maintains
original behavior where (opened) interface type is adjusted via
FunctionConversionExprto a type with appropriate concurrency annotations.
Scope: Partial applications with
InferSendableFromCapturesfeature enabled.Main Branch PRs: [TypeChecker] InferSendableFromCaptures: Infer
@Sendableon adjusted types #72527Resolves: rdar://119593407
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the test suite.