AST: Request-ify ValueDecl::findImport()
#72758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent performance regressions from calling `findImport()` more frequently, request-ify the computation. NFC. Prerequisite of rdar://16154294
|
@swift-ci please smoke test |
slavapestov
reviewed
Apr 2, 2024
| auto &ctx = sf->getASTContext(); | ||
| auto imports = sf->getImports(); | ||
|
|
||
| // Look to see if the owning module was directly imported. |
There was a problem hiding this comment.
There's an overload of ImportCache::getImportSet() that takes an ArrayRef. Maybe it can replace this whole thing?
There was a problem hiding this comment.
This was originally located in TypeCheckConcurrency, so there is a high chance that it’s possible to dedupe…
There was a problem hiding this comment.
It looks like ImportSet is a flat set of imports, so the context of which top level import each transitive import comes from is lost. Correct me if I'm missing something but I don't see how that can be used to implement this request that needs to return the specific import from which a module is reachable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent performance regressions from calling
findImport()more frequently, request-ify the computation.NFC.
Prerequisite of rdar://16154294