[region-isolation] Require T in assumeIsolated<T> to be Sendable. #72763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@tshortli is it safe to do what I am doing here if a function was back deployed? |
tshortli
reviewed
Apr 2, 2024
ktoso
approved these changes
Apr 2, 2024
gottesmm
force-pushed
the
pr-d6b1f7e0bfc91f3d28ecf7bd100f45f41533688a
branch
5 times, most recently
from
dae432a to
1c2f544
Compare
|
@swift-ci test |
tshortli
approved these changes
Apr 2, 2024
|
@swift-ci smoke test linux platform |
I had to change the APIs to always be always emit into client instead of back deployable since silgen_name seems to interfere with @backDeployment. So I switched the implementation so that it instead uses an always emit into client thunk with the in source function name and a usableFromInline function that has the silgen_name. This ensures that we still appropriately export the same symbol as we did before, so it is ABI stable. This was approved as part of se-0414. rdar://122030520
gottesmm
force-pushed
the
pr-d6b1f7e0bfc91f3d28ecf7bd100f45f41533688a
branch
from
1c2f544 to
cf93476
Compare
gottesmm
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci test |
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux platform |
1 similar comment
|
@swift-ci smoke test Linux platform |
|
@swift-ci smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the APIs to always be always emit into client instead of back deployable since silgen_name seems to interfere with @backDeployment. So I switched the implementation so that it instead uses an always emit into client thunk with the in source function name and a usableFromInline function that has the silgen_name. This ensures that we still appropriately export the same symbol as we did before, so it is ABI stable.
This was approved as part of se-0414.
rdar://122030520