Skip to content

[cxx-interop] Use C++17 standard by default #72766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

egorzhdan
Copy link
Contributor

Clang is using C++17 standard version by default since Clang 16.

Swift’s ClangImporter should do the same, to make sure that clients who run clang and then swiftc without explicit std version see consistent behavior.

rdar://125777068

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 2, 2024
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners April 2, 2024 13:55
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test source compatibility

Clang is using C++17 standard version by default since Clang 16.

Swift’s ClangImporter should do the same, to make sure that clients who run clang and then swiftc without explicit std version see consistent behavior.

rdar://125777068
@egorzhdan egorzhdan force-pushed the egorzhdan/bump-std-default branch from 695a792 to 1be7230 Compare April 2, 2024 15:24
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test source compatibility

Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goo

@egorzhdan
Copy link
Contributor Author

@swift-ci please test macOS

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please test macOS

@egorzhdan egorzhdan merged commit a0c1027 into main Apr 3, 2024
@egorzhdan egorzhdan deleted the egorzhdan/bump-std-default branch April 3, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants