[cxx-interop][IRGen] Assign Clang function types to copy constructors #72770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the right way to test this, let me think for a bit |
|
@swift-ci please test |
egorzhdan
force-pushed
the
egorzhdan/clang-fn-type-copy-ctor
branch
from
b716967 to
4bb7a0c
Compare
|
@swift-ci please test |
kubamracek
approved these changes
Apr 3, 2024
This fixes an assertion failure when building certain projects for arm64e with `-use-clang-function-types` Swift compiler flag: ``` Expected non-null Clang type for @convention(c)/@convention(block) function but found nullptr ``` rdar://121227452
egorzhdan
force-pushed
the
egorzhdan/clang-fn-type-copy-ctor
branch
from
4bb7a0c to
802f20e
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an assertion failure when building certain projects for arm64e with
-use-clang-function-typesSwift compiler flag:rdar://121227452