[6.0] Enable failable initializers of noncopyable types #72779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…members An empty struct that is noncopyable can nonetheless have a `deinit`, so it is not trivially destructible. In such cases, embedded them in another empty struct means that the outer struct should also not be trivially destructible. Make it so. (cherry picked from commit b19a325)
Noncopyable types were prevented from having failable initializers because `Optional` itself didn't support noncopyable types. Now `Optional` does, so lift this restriction and add a test. (cherry picked from commit bd696f9)
Only the non-zero-sized associated values of a type were considered when determining whether an enum is copyable or was trivially-destructible, meaning that a zero-sized, noncopyable type with a `deinit` wouldn't get destroyed. Treat these associated values as if they were a payload, and centralize the logic for figuring out these overall aspects of the enum (copyable, trivially-destructible, bitwise-takable) since the same checks were repeated. Fixes rdar://118449507.
|
@swift-ci please test |
|
@swift-ci please test macOS |
hborla
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init?) were disabled on noncopyable types early on becauseOptionalcouldn't support noncopyable types. Now that it does, lift this restriction, fixing two miscompiles involving empty noncopyable types withdeinits along the way.