Runtime: add a non-Darwin error message storage #72785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
approved these changes
Apr 3, 2024
|
From the Embedded Swift perspective: This change LGTM -- it doesn't change anything around Embedded Swift, as Errors.cpp is not part of the Embedded Swift Runtime. I think it's fine to proceed as is, because (1) Embedded Swift shouldn't get any any non-essential runtime facilities, (2) in production builds, it already today has fatalErrors() not print the error message, and the error message string is not even present in the binaries (to minimize codesize), (3) the crash message should be recoverable from debuginfo (4) given the highly experimental state of Embedded Swift, we can always revisit and change the status quo later. |
mikeash
approved these changes
Apr 5, 2024
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
This introduces a non-Darwin (non-CrashReporter) storage for error messages to allow extraction for crash reporting. This is initially meant to be used on Windows, though it is generic enough to be used on any platform.
|
@swift-ci please test |
|
@compnerd I am seeing a compilation error possibly due to this PR on ubuntu 18.04 : https://ci.swift.org/job/oss-swift-RA-lsan-linux-ubuntu-18_04/10040/console |
|
@meg-gupta interesting; seems like it is an overload mismatch? It might require an explicit cast? I'll see if I can get away with casting away the const-ness on all the platforms. Is there an easy way to trigger the runs on the 18.04 builder? |
|
Mishal pointed me to https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#build-swift-toolchain. You can use - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a non-Darwin (non-CrashReporter) storage for error messages to allow extraction for crash reporting. This is initially meant to be used on Windows, though it is generic enough to be used on any platform.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves #NNNNN, fix apple/llvm-project#MMMMM.