[6.0] Rename StringRef::endswith references to StringRef::ends_with
#72791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missed this when doing the `startswith` renaming. `endswith` has also been deprecated upstream (and presumably soon to be removed). (cherry picked from commit 1fdda02)
hborla
approved these changes
Apr 3, 2024
|
@swift-ci please test |
|
Just going to close this, no one has seemed bothered so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: A simple rename from
endswith->ends_with, which has been renamed upstream. This isn't strictly necessary for 6.0, but should ease cherry-picks. I had made thestartswithrename prior to the branch, but forgot aboutendswith.Scope: NFC as long as it builds - LLVM has both
endswithandends_withdefined.Original PR: #72744
Risk: NFC as long as it builds.
Testing: No specific tests, it either builds or doesn't.