[embedded] Avoid a crash on location-less SIL functions in PerformanceDiagnostics #72819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
eeckstein
reviewed
Apr 5, 2024
| if (getMethodDispatch(func) == MethodDispatch::Class) { | ||
| vtableMembers.push_back(&function); | ||
| continue; | ||
| if (function.hasLocation()) { |
There was a problem hiding this comment.
Can you add a short comment saying why there are functions with no locations and why it's okay to not check those?
There was a problem hiding this comment.
Will add comment. We still check all functions, even those without a location -- this code here picks some functions to be checked first and last (to improve diagnostic quality). Whatever isn't matched here still goes into the others arrays.
…n PerformanceDiagnostics
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that SILGen can generate calls to things like
swift_readAtKeyPath, which end up being location-less SILFunctions. Let's avoid crashing on those in PerformanceDiagnostics. The attached test case previously failed with:rdar://125724841