[region-isolation] Enable by default when strict concurrency is enabled #72851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs when working with ActorIsolation in SIL. This lets us avoid needing to depend on the AST for getting ActorIsolation for self parameters. Now, we can just create the actor isolation we need based off of the decl that we have. The code is based off of forActorInstanceSelf(ValueDecl *decl) along the path where it just creates isolation based off of the decl's nominal type decl (which is equivalent to what we are trying to do here).
…olation instead of that or nominal type decls. This should be NFC since the only case where I used this was with self... and I found another way of doing that using the API I added in the previous commit.
…currency. I added a disable flag -disable-region-based-isolation-with-strict-concurrency so that we do not need to update the current tests. It is only available when asserts are enabled to ensure users cannot use it. rdar://125918028
gottesmm
requested review from
kavon,
ktoso,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci smoke test |
drodriguez
reviewed
Apr 5, 2024
| @@ -1,5 +1,5 @@ | |||
| // RUN: %target-swift-frontend -disable-availability-checking -strict-concurrency=complete %s -emit-sil -o /dev/null -verify -verify-additional-prefix complete- | |||
| // RUN: %target-swift-frontend -disable-availability-checking -strict-concurrency=complete %s -emit-sil -o /dev/null -verify -enable-upcoming-feature RegionBasedIsolation | |||
| // RUN: %target-swift-frontend -disable-availability-checking -strict-concurrency=complete %s -emit-sil -o /dev/null -verify -verify-additional-prefix complete- -disable-region-based-isolation-with-strict-concurrency | |||
There was a problem hiding this comment.
Does it need a REQUIRES: asserts to keep working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[region-isolation] Enable region isolation by default with strict-concurrency.
I added a disable flag -disable-region-based-isolation-with-strict-concurrency
so that we do not need to update the current tests. It is only available when
asserts are enabled to ensure users cannot use it.
rdar://125918028
I also added a small fix that makes sure that we only traffic in ActorIsolation instead of sometimes using ActorIsolation and sometimes just using a nominal type. This eliminates a potential assertion that we could hit due to inconsistencies.