[6.0] Fix two bugs with opaque return types -vs- parameter packs #72853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fix-variadic-opaque-6.0
branch
from
6016887 to
5ea91ad
Compare
The names of the private witness table accessor thunks we generate for an opaque return type mangle the concrete conformance of the underlying type. If a conformance requirement of the opaque return type was witnessed by a conditional conformance of a variadic generic type, we would crash because of an unimplemented case in the mangler. Fixes rdar://problem/125668798.
…ePackExpansionLevel Fixes rdar://problem/123645784.
slavapestov
force-pushed
the
fix-variadic-opaque-6.0
branch
from
5ea91ad to
8f713a9
Compare
|
@swift-ci Please test |
hborla
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 cherry-pick of key bits of #72847
Description: Fix infinite recursion in opaque type substitution when parameter packs are present, and a crash when opaque return type witnessed by variadic generic type with conditional conformance.
Reviewed by: @hborla
Risk: Low
Radar: rdar://123645784, rdar://125668798