AST: Fix a couple _diagnoseUnavailableCodeReached() crashes for zippered libraries
#72858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declarations in a zippered macOS library may be referenced by clients that build either for macOS or for macCatalyst. It is therefore inappropriate to stub functions in zippered libraries as "unreachable" when they are only unavailable on macOS. Making this logic correct is a larger project, so for now just disable stubbing when there is a target variant. Resolves rdar://125371621
…ivation. When deriving `Hashable` and `Equatable` for enums, use `Decl::isUnreachableAtRuntime()` to determine whether or not to insert `_diagnoseUnavailableCodeReached()` traps for specific enum elements. This fixes a bug where inappropriate traps were inserted for enum elements that are unavailable for app extensions. It also fixes a bug where traps were inserted when building a zippered library for macOS and enum elements were unavailable on macOS but not for macCatalyst clients. Resolves rdar://125371621
|
@swift-ci please smoke test |
artemcm
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarations in a zippered macOS library may be referenced by clients that build either for macOS or for macCatalyst. It is therefore inappropriate to stub functions in zippered libraries as "unreachable" when they are only unavailable on macOS. The same issue also affects the derived
HashableandEquatableconformances for enums with unavailable elements. Making this logic correct is a larger project, so for now we're more conservative about classifying a declaration as unreachable when a target variant is present during compilation.Resolves rdar://125371621