Move Float16 print tests to their own file and test exhaustively #72859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vely. We can easily test all 2**16 values, so let's do it. Also now _Float16 is properly supported in clang, so we can pass arguments to CPP that way, which lets us get snan right on more platforms.
mikeash
approved these changes
Apr 5, 2024
And fixup availability for x86 that was copied from another branch.
stephentyrone
force-pushed
the
exhaustive-test-float16-printing
branch
from
3da90d6 to
dd72aa3
Compare
|
@swift-ci smoke test |
Apparently clang/windows (sigh) doesn't define FLT16_MAX in <float.h>, so we have to keep using the _p interface instead.
|
@swift-ci smoke test |
glessard
approved these changes
Apr 5, 2024
stephentyrone
added a commit
that referenced
this pull request
Apr 19, 2024
) (#73106) We can easily test all 2**16 values, so let's do it. Also now _Float16 is properly supported in clang, so we can pass arguments to CPP that way, which lets us get snan right on more platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can easily test all 2**16 values, so let's do it. Also now _Float16 is properly supported in clang, so we can pass arguments to CPP that way, which lets us get snan right on more platforms and just generally make things cleaner.