[DebugInfo] Salvage debug info for tuples #72860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable" This reverts commit e63632f. rdar://125939953
Snowy1803
force-pushed
the
salvage-debug-info-tuple
branch
2 times, most recently
from
4081ea4 to
38a0f3f
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
@swift-ci Please Test Source Compatibility |
adrian-prantl
approved these changes
Apr 5, 2024
|
Source Compatibility failures are the same as on main (Debug PR = Debug on main | Release (passing)) |
Snowy1803
force-pushed
the
salvage-debug-info-tuple
branch
from
38a0f3f to
cda8f15
Compare
Snowy1803
force-pushed
the
salvage-debug-info-tuple
branch
from
cda8f15 to
1e7dc51
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for salvaging removed
tupleSIL instructions.implicitattribute for debug variables. The implicit attribute meant that implicit variables, such asself,errorin a catch,newValuein a property setter, etc., were allowed to be removed at-Onone! rdar://125939953tupleSIL instructionsWith only the second commit, those variables were being removed at Onone and salvaged, which unexpectedly introduced fragments at Onone, which are not compatible with debugger shadow copies. After reverting the implicit attribute, the fragments are now correctly only created when optimizations are enabled.