[Concurrency] Classes nested in actors are not semantically final. #72863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
approved these changes
Apr 5, 2024
|
@swift-ci please smoke test |
The check for actor methods in `isSemanticallyFinal` was accidentally kicking in for class members, which avoided `Sendable` checking on classes nested in actors.
hborla
force-pushed
the
nested-sendable-class
branch
from
66b7863 to
537d7a5
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for actor methods in
isSemanticallyFinalwas accidentally kicking in for class members, which avoidedSendablechecking on classes nested in actors.Resolves: rdar://118904081