Skip to content

Revert "[TypeChecker] TypeChecker::isSubtypeOf should recognize Sendable/@Sendable subtyping" #72868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Apr 5, 2024

Original PR - #70502

This approach regressed existing ternary expressions that join to any Sendable
and one branch is inferred from the ternary type variable.

The test-cases introduced by the original PR I left in place with error messages and
TODOs to figure out a way to resolve ambiguity.

@xedin
Copy link
Contributor Author

xedin commented Apr 5, 2024

@swift-ci please test

xedin added 2 commits April 5, 2024 00:23
…gnize @sendable subtyping"

Reverts code chagnes introduced by 5626881 but leaves (modified) test-cases

This approach regressed existing ternary expressions that join to `any Sendable`
and one branch is inferred from the ternary type variable.
@xedin xedin force-pushed the revert-subtype-with-sendable-changes branch from b931f54 to 6a60588 Compare April 5, 2024 07:25
@xedin
Copy link
Contributor Author

xedin commented Apr 5, 2024

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant