[Runtime] Disable prespecialized metadata if we have overridden images. #72873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to check for overridden images on every image load, otherwise XCTest (among others) may `dlopen()` an image that pulls in something that is overridden, at which point the prespecialized metadata won't match the image we loaded. rdar://125727356
|
Explanation: We need to turn off prespecialized metadata if we've overridden an image in the shared cache. |
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
tbkka
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to check for overridden images on every image load, otherwise XCTest (among others) may
dlopen()an image that pulls in something that is overridden, at which point the prespecialized metadata won't match the image we loaded.rdar://125727356