[cxx-interop] Pull changes from swift-6 compat mode into swift-5.9
#72912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
Swift-5.10 is not a valid interop version. Do you want to use 5.9 instead? |
egorzhdan
force-pushed
the
egorzhdan/cxx-interop-compat-mode
branch
from
518cb0b to
19d8ea6
Compare
|
🤦♂️ Right, thank you! |
|
@swift-ci please test |
egorzhdan
changed the title
swift-6 compat mode into swift-5.10swift-6 compat mode into swift-5.9
egorzhdan
force-pushed
the
egorzhdan/cxx-interop-compat-mode
branch
2 times, most recently
from
9f1e8d1 to
eca9ccc
Compare
egorzhdan
requested review from
zoecarver,
hyp,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test macOS |
|
Hmm, this only seems to fail on macOS, and only with a release compiler: |
|
Ah! We're importing |
egorzhdan
added a commit
that referenced
this pull request
Apr 16, 2024
…ble generics are disabled C++ pointer type `T*` is generally imported as `Unsafe(Mutable)Pointer<T>`. However, if `T` is non-copyable in Swift (e.g. it has a deleted C++ copy constructor), using `UnsafePointer<T>` type requires noncopyable generics to be enabled. This was causing assertion failures when building SwiftCompilerSources in #72912.
egorzhdan
force-pushed
the
egorzhdan/cxx-interop-compat-mode
branch
from
b987e72 to
c37a685
Compare
|
@swift-ci please test |
egorzhdan
added a commit
that referenced
this pull request
Apr 16, 2024
… generics are disabled C++ pointer type `T*` is generally imported as `Unsafe(Mutable)Pointer<T>`. However, if `T` is non-copyable in Swift (e.g. it has a deleted C++ copy constructor), using `UnsafePointer<T>` type requires noncopyable generics to be enabled. This was causing assertion failures when building SwiftCompilerSources in #72912.
egorzhdan
added a commit
that referenced
this pull request
Apr 18, 2024
… generics are disabled C++ pointer type `T*` is generally imported as `Unsafe(Mutable)Pointer<T>`. However, if `T` is non-copyable in Swift (e.g. it has a deleted C++ copy constructor), using `UnsafePointer<T>` type requires noncopyable generics to be enabled. This was causing assertion failures when building SwiftCompilerSources in #72912.
egorzhdan
added a commit
that referenced
this pull request
Apr 23, 2024
… generics are disabled C++ pointer type `T*` is generally imported as `Unsafe(Mutable)Pointer<T>`. However, if `T` is non-copyable in Swift (e.g. it has a deleted C++ copy constructor), using `UnsafePointer<T>` type requires noncopyable generics to be enabled. This was causing assertion failures when building SwiftCompilerSources in #72912.
This gives projects using C++ interop compat mode 5.9 access to the new features such as virtual methods and move-only types. rdar://126485814
egorzhdan
force-pushed
the
egorzhdan/cxx-interop-compat-mode
branch
from
c37a685 to
b330376
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Apr 24, 2024
egorzhdan
added a commit
that referenced
this pull request
Apr 24, 2024
… generics are disabled C++ pointer type `T*` is generally imported as `Unsafe(Mutable)Pointer<T>`. However, if `T` is non-copyable in Swift (e.g. it has a deleted C++ copy constructor), using `UnsafePointer<T>` type requires noncopyable generics to be enabled. This was causing assertion failures when building SwiftCompilerSources in #72912. (cherry picked from commit 78eee32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives projects using C++ interop compat mode 5.9 access to the new features such as virtual methods and move-only types.
rdar://126485814