Requestify LifetimeDependenceInfo #72916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query and cache lifetime dependence info via evaluator requests
meg-gupta
force-pushed
the
lifetimedepreq
branch
from
9514caa to
d576e1d
Compare
|
@swift-ci test |
|
@swift-ci build toolchain |
meg-gupta
requested review from
hborla,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro,
AnthonyLatsis and
eeckstein
as code owners
meg-gupta
force-pushed
the
lifetimedepreq
branch
from
d576e1d to
afd2052
Compare
|
@swift-ci smoke test |
slavapestov
approved these changes
Apr 9, 2024
| } | ||
|
|
||
| std::optional<LifetimeDependenceInfo> | ||
| LifetimeDependenceInfo::infer(AbstractFunctionDecl *afd, Type resultType) { | ||
| LifetimeDependenceInfo::infer(AbstractFunctionDecl *afd) { |
There was a problem hiding this comment.
In a subsequent PR, please refactor this logic so that LifetimeDependence methods are implemented in AST. Perhaps these functions can just be static, if they're only used in the implementation of the request evaluate() method?
| @@ -3098,3 +3097,9 @@ ImplicitKnownProtocolConformanceRequest::evaluate(Evaluator &evaluator, | |||
| llvm_unreachable("non-implicitly derived KnownProtocol"); | |||
| } | |||
| } | |||
|
|
|||
| std::optional<LifetimeDependenceInfo> | |||
| LifetimeDependenceInfoRequest::evaluate(Evaluator &evaluator, | |||
There was a problem hiding this comment.
You can move this into lib/Sema/LifetimeDependence.cpp, and turn LifetimeDependence::get() into a static method
|
Should this be cherry-picked to 6.0? Or is it too intrusive a change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the request evaluator method to query LifetimeDependenceInfo
With this change, LifetimeDependenceInfo is serialized in both explicit and inferred cases. And on deserialization, LifetimeDependenceInfo is cached on the decl, so that InterfaceTypeRequest does not have to recompute this info.
Also piggybacking some minor changes.