[6.0] AST: Remove incorrect optimization from ASTContext::getOpenedExistentialSignature() #72920
+25
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialSignature() It is no longer true that the existential signature of `any P` is always just `<Self where Self: P>`, because `P` might be `~Copyable`, in which case `any P` is really `any P & Copyable`. Just remove the micro-optimization here, because if we're building an existential signature, we're likely going to be doing generic signature queries, and then we'll need a Requirement Machine anyway. This happened to manifest in the SIL optimizer when performing the concrete existential peephole with `any Sendable`, since Sendable is now ~Copyable. Fixes rdar://problem/126079282.
slavapestov
changed the title
|
@swift-ci Please test |
hborla
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 cherry-pick of #72919.
Description: It is no longer true that the existential signature of
any Pis always just<Self where Self: P>, becausePmight be~Copyable, in which caseany Pis reallyany P & Copyable. Just remove the micro-optimization here, because if we're building an existential signature, we're likely going to be doing generic signature queries, and then we'll need a Requirement Machine anyway.Scope of the issue: This happened to manifest in the SIL optimizer when performing the concrete existential peephole with
any Sendable, since Sendable is now ~Copyable, but any number of code paths could have run into this.Radar: Fixes rdar://problem/126079282.
Reviewed by: @hborla