Skip to content

Disable and fix some failing tests in CI #72922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2024
Merged

Disable and fix some failing tests in CI #72922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
afb65c2
Disable some distributed actor tests on arm64e
meg-gupta Apr 9, 2024
9e79964
Disable DebugInfo tests on watchos
meg-gupta Apr 9, 2024
5380f4d
Disable an Interop test in CI
meg-gupta Apr 9, 2024
da0cf86
add the swift_clearSensitive runtime function
meg-gupta Apr 9, 2024
93eeee7
Disable some concurrency tests
meg-gupta Apr 9, 2024
9112760
Disable failing test on arm64
meg-gupta Apr 9, 2024
5ced6cc
Disable test Runtime/issue-51181.swift
meg-gupta Apr 9, 2024
2b337a3
Disable test Sanitizers/asan/recover.swift
meg-gupta Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/Concurrency/Runtime/async_task_executor_structured_concurrency.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

// REQUIRES: concurrency_runtime
// UNSUPPORTED: back_deployment_runtime
// rdar://126118749
// UNSUPPORTED: CPU=arm64e

import Dispatch
import StdlibUnittest
Expand Down
3 changes: 3 additions & 0 deletions test/Concurrency/isolation_macro_availability.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
// REQUIRES: swift_swift_parser
// REQUIRES: VENDOR=apple

// rdar://126118470
// UNSUPPORTED: CPU=arm64e

@available(SwiftStdlib 5.1, *)
func isolatedFunc(isolation: isolated (any Actor)? = #isolation) {}

Expand Down
2 changes: 1 addition & 1 deletion test/DebugInfo/BuiltinStdlibTypes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %target-swift-frontend %s -Onone -emit-ir -gdwarf-types -o - | %FileCheck %s

// rdar://124465351
// UNSUPPORTED: CPU=armv7k
// UNSUPPORTED: OS=watchos

// File is empty as this test check for the builtin stdlib types that should
// always be emitted.
Expand Down
2 changes: 1 addition & 1 deletion test/DebugInfo/classes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// RUN: %target-swift-frontend -primary-file %s -emit-ir -gdwarf-types -o - | %FileCheck %s

// rdar://124465351
// UNSUPPORTED: CPU=armv7k
// UNSUPPORTED: OS=watchos

class SomeClass {
let first = 4
Expand Down
3 changes: 3 additions & 0 deletions test/Distributed/Runtime/distributed_actor_localSystem_distributedProtocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
// rdar://90373022
// UNSUPPORTED: OS=watchos

// rdar://125628060
// UNSUPPORTED: CPU=arm64e

import Distributed

@_DistributedProtocol
Expand Down
3 changes: 3 additions & 0 deletions test/Distributed/Runtime/distributed_actor_localSystem_manual_conformance.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
// rdar://90373022
// UNSUPPORTED: OS=watchos

// rdar://125628060
// UNSUPPORTED: CPU=arm64e

import Distributed

@available(SwiftStdlib 6.0, *)
Expand Down
2 changes: 1 addition & 1 deletion test/Interop/SwiftToCxx/enums/enum-associated-value-class-type-cxx.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// RUN: %check-interop-cxx-header-in-clang(%t/enums.h -Wno-unused-private-field -Wno-unused-function)

// rdar://124466216
// UNSUPPORTED: CPU=armv7k
// UNSUPPORTED: OS=watchos

public class C {
public var x: Int
Expand Down
1 change: 1 addition & 0 deletions test/Sanitizers/asan/recover.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// REQUIRES: executable_test
// REQUIRES: asan_runtime
// UNSUPPORTED: OS=windows-msvc
// REQUIRES: rdar126150190

// Check with recovery instrumentation and the runtime option to continue execution.
// RUN: %target-swiftc_driver %s -g -sanitize=address -sanitize-recover=address -import-objc-header %S/asan_interface.h -emit-ir -o %t.asan_recover.ll
Expand Down
1 change: 1 addition & 0 deletions test/abi/macOS/x86_64/stdlib.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,7 @@ Added: __swift_exceptionPersonality
Added: _swift_willThrowTypedImpl
Added: __swift_willThrowTypedImpl
Added: __swift_enableSwizzlingOfAllocationAndRefCountingFunctions_forInstrumentsOnly
Added: _swift_clearSensitive
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eeckstein This change seems to have been left out from - ce33d47

Added here because this test is failing .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


// Runtime bincompat functions for Concurrency runtime to detect legacy mode
Added: _swift_bincompat_useLegacyNonCrashingExecutorChecks
1 change: 1 addition & 0 deletions validation-test/Runtime/issue-51181.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// RUN: %target-run-simple-swift
// REQUIRES: executable_test
// REQUIRES: rdar126151157

// https://github.com/apple/swift/issues/51181

Expand Down
2 changes: 1 addition & 1 deletion validation-test/stdlib/StringGraphemeBreaking.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// REQUIRES: optimized_stdlib

// rdar://124539686
// UNSUPPORTED: CPU=arm64e
// UNSUPPORTED: CPU=arm64e, CPU=arm64

import StdlibUnittest
import StdlibUnicodeUnittest
Expand Down