[6.0] Fix type lowering of ~Copyable and ~Escapable generics. #72946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes TypeLowering for ~Copyable generics, such as:
struct S<T: ~Copyable>: ~Copyable {
var x: T
}
extension S: Copyable where T: Copyable {}
func foo<T>(s: S<T>) -> ()
Previously, TypeLowering would ignore the implicit Copyable
requirement on the archetype 'T'.
(cherry picked from commit 22646bd)
(cherry picked from commit 9bd9218)
Factor AbstractionPattern::conformsToKnownProtocol and lower ~Escapable using the same logic as ~Copyable.
Adds support for conditionally Escapable enums.
Correctly sets the SILType::isTrivial flags for conditionally escapable structs and enums in environments (extensions)
that provide an Escapable conformance, such as:
struct NE<E: ~Escapable> : ~Escapable {}
extension NE: Escapable {
func foo() -> Self {
// Self is both Escapable and trivial here.
self
}
}
Fixes rdar://125950218 ([nonescapable] support conditionally escapable enums)
(cherry picked from commit a90b515)
(cherry picked from commit 4f0680c)
|
@swift-ci test |
tbkka
approved these changes
Apr 10, 2024
This is needed until initializer inference is merged. Then these extra initializers can simply be deleted.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- CCC ---
Explanation: Fix type lowering of ~Copyable and ~Escapable generics.
Scope: Required to correctly suppress move-only diagnostics of conditionally copyable types when the type is statically copyable. Required to allow the definition of nonescapable enums.
Radar/SR Issues: rdar://125950218 ([nonescapable] support conditionally escapable enums)
Original PR: #72866
Risk: This only suppresses move-only diagnostics in some cases. It allows the use of ~Escapable on enums, which would always crash before.
Testing: Unit tests added
Reviewer: @slavapestov