[Embedded] Add armv4t to list of recognized architectures #73005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain |
harlanhaskins
changed the title
harlanhaskins
requested review from
a team,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
phausler
reviewed
Apr 13, 2024
There was a problem hiding this comment.
generally this looks fine to me; @kubamracek is there any other spots that need to be changed such that we ship a armv4 stdlib?
| @@ -60,6 +60,8 @@ static std::string adjustClangTriple(StringRef TripleStr) { | |||
| OS << "armv5"; break; | |||
| case llvm::Triple::SubArchType::ARMSubArch_v5te: | |||
| OS << "armv5te"; break; | |||
| case llvm::Triple::SubArchType::ARMSubArch_v4t: | |||
| OS << "armv4t"; break; | |||
There was a problem hiding this comment.
does this work more generally for armv4? are there other embedded cpus that would be good examples?
There was a problem hiding this comment.
I suppose I could add armv4, but I don’t have any readily available armv4 hardware that I can test against. It probably works just fine though.
| @@ -183,6 +183,7 @@ if(SWIFT_SHOULD_BUILD_EMBEDDED_STDLIB) | |||
| # the following are all ELF targets | |||
| if("ARM" IN_LIST LLVM_TARGETS_TO_BUILD) | |||
| list(APPEND EMBEDDED_STDLIB_TARGET_TRIPLES | |||
| "armv4t armv4t-none-none-eabi armv4t-none-none-eabi" | |||
There was a problem hiding this comment.
is the GBA llvm toolchain elf based?
There was a problem hiding this comment.
Yep, GBA ROMs are ELF
|
Very nice! 😊 |
kubamracek
approved these changes
Apr 13, 2024
rauhul
approved these changes
Apr 13, 2024
harlanhaskins
deleted the
harlan/you-put-your-right-arm-in-you-put-your-left-arm-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds armv4t as a recognized embedded architecture and builds a stdlib module for it.
Since LLVM natively supports armv4t, this is all that's needed to write Swift for the Game Boy Advance, if you combine it with the GBA LLVM toolkit from https://github.com/stuij/gba-llvm-devkit.