Skip to content

IRGen: Freeze undef switch, select, cond_br arguments #73020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

aschwaighofer
Copy link
Contributor

Let's make cond_br undef : $Builtin.Int1, then, else (and the like) a defined LLVM IR operation with un-specfied behavior.

rdar://126231554

@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer
Copy link
Contributor Author

Where did half of the patch go ...

Let's make `cond_br undef : $Builtin.Int1, then, else` (and the like) a defined
LLVM IR operation with un-specfied behavior.

rdar://126231554
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

I don't really understand how the address case happens, but I guess we don't need to worry about it.

@aschwaighofer
Copy link
Contributor Author

I don’t know that it does

@aschwaighofer
Copy link
Contributor Author

@swift-ci test

@aschwaighofer aschwaighofer merged commit 49d31ef into main Apr 13, 2024
@aschwaighofer aschwaighofer deleted the freeze branch April 13, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants