[6.0] CMake: add a missing dependency to fix the bootstrapping build #73034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Apr 15, 2024
eeckstein
commented
- Explanation: Legacy layouts must be copied before the bootstrapping compiler is used to build the SwiftCompilerSources Fixes a sporadic build failure due to missing legacy layout files
- Scope: Only affects the compiler build process
- Risk: very low. The only change is an additional CMake build dependency
- Testing: Tested by various CI jobs
- Issue: rdar://126305248
- Reviewer: @edymtt
- Main branch PR: CMake: add a missing dependency to fix the bootstrapping build #73000
legacy layouts must be copied before the bootstrapping compiler is used to build the SwiftCompilerSources Fixes a sporadic build failure due to missing legacy layout files
|
@swift-ci test |
eeckstein
changed the title
|
@swift-ci test windows |
airspeedswift
approved these changes
Apr 15, 2024
edymtt
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.