[SILGen] Fix a bug where the wrong convention was being used for lowering a closure to a C++ function pointer #73039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowering a closure to a C++ function pointer Use the C function pointer convention instead of the block convention. rdar://122977380
|
@swift-ci please test |
egorzhdan
reviewed
Apr 15, 2024
| @@ -141,3 +141,8 @@ module CopyMoveAssignment { | |||
| header "copy-move-assignment.h" | |||
| requires cplusplus | |||
| } | |||
|
|
|||
| module NonTrivialClasses { | |||
There was a problem hiding this comment.
Should we call this module Closures, since closures are the special thing in this test module?
| @@ -0,0 +1,21 @@ | |||
| // RUN: %target-swiftxx-frontend -I %S/Inputs -emit-silgen %s | %FileCheck %s | |||
There was a problem hiding this comment.
Could you please also add an execution test? That would help to make sure we don't crash in IRGen or at runtime.
There was a problem hiding this comment.
I can add an execution test, but IRGen will still be incorrect until we fix #73019.
Notice that the parameter of the thunk in the test case is @in NonTrivial, which means the destructor is called in the thunk. Calling cfunc2 would result in a double-free crash if NonTrivial was defined as follows:
struct NonTrivial {
NonTrivial() { p = new int(123); }
~NonTrivial() { delete p; }
int *p = nullptr;
};
void cfunc2(void (*fp)(NonTrivial)) {
NonTrivial t;
(*fp)(t);
}
- Rename module. - Fix check string in test - Add execution test
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the C function pointer convention instead of the block convention.
rdar://122977380