Skip to content

IRGen: Cast an ObjC allocation to the instantiated class type #7306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2017
Merged

IRGen: Cast an ObjC allocation to the instantiated class type #7306

merged 1 commit into from
Feb 10, 2017
+50 −1

Conversation

aschwaighofer
Copy link
Contributor

Lowering of phi nodes expects the more refined type rather than objc_object.

rdar://30268690

@aschwaighofer
IRGen: Cast an ObjC allocation to the instantiated class type
2307145 
Lowering of phi nodes expects the more refined type rather than objc_object.

rdar://30268690
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 7, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2307145
Test requested by - @aschwaighofer

@swift-ci
Copy link
Contributor

swift-ci commented Feb 7, 2017

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 2307145
Test requested by - @aschwaighofer

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test

1 similar comment
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2307145
Test requested by - @aschwaighofer

@aschwaighofer
Copy link
Contributor Author

The linux failure is unrelated -- lldb's TestWeakSelf.py -- also failed on other PR (https://ci.swift.org/job/swift-PR-Linux/5502).

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test linux

@swift-ci
Copy link
Contributor

swift-ci commented Feb 8, 2017

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 2307145
Test requested by - @aschwaighofer

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test linux platform

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please smoke test os x platform

@aschwaighofer aschwaighofer merged commit ab7128e into swiftlang:master Feb 10, 2017
@bob-wilson bob-wilson mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aschwaighofer @swift-ci