Remove swift-nio-ssl from main scheme #73069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci build toolchain |
|
Don't we need swift-nio to build swift-docc? https://github.com/apple/swift-docc/blob/0c546df1a341b81a94e9b67e38cdf5801d49802f/Package.swift#L147 Additionally, swift-sdk-generator will use it too. CC: @MaxDesiatov |
MaxDesiatov
previously requested changes
Apr 17, 2024
There was a problem hiding this comment.
Removing swift-nio would prevent Swift SDK Generator from building on Swift CI as a part of Wasm jobs, which is what we're trying to do in #72931.
shahmishal
changed the title
|
@swift-ci build toolchain |
|
@swift-ci build toolchain macOS |
MaxDesiatov
dismissed
their stale review
Dismissing change request as addressed
|
@swift-ci smoke test |
kateinoigakukun
approved these changes
Apr 18, 2024
MaxDesiatov
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.