Skip to content

[Debugging] Add DebugDescriptionMacro experimental feature #73070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Apr 16, 2024

This removes the leading underscore from the macro.

@kastiglione kastiglione requested a review from a team as a code owner April 16, 2024 22:37
@kastiglione
Copy link
Contributor Author

@swift-ci smoke test

@kastiglione
Copy link
Contributor Author

@swift-ci test macOS

@kastiglione
Copy link
Contributor Author

@swift-ci linux macOS

@kastiglione
Copy link
Contributor Author

@swift-ci test linux

@kastiglione kastiglione merged commit 4ccf315 into release/6.0 Apr 17, 2024
@kastiglione kastiglione deleted the dl/Debugging-Add-DebugDescriptionMacro-experimental-feature branch April 17, 2024 18:23
@drodriguez
Copy link
Contributor

Does this need some handling of asserts vs. no asserts compiler?

@kastiglione
Copy link
Contributor Author

@drodriguez I don't believe so

@drodriguez
Copy link
Contributor

Using the build-script and doing --no-assertions I end up in error: experimental feature 'DebugDescriptionMacro' cannot be enabled in production compiler. Reverting this diff I don't get the same.

@kastiglione
Copy link
Contributor Author

Thanks, I see the problem. Fix here #73097

kastiglione added a commit that referenced this pull request Apr 18, 2024
This removes the leading underscore from the macro.

(cherry picked from commit 4ccf315)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants