[6.0] Map the isolated variable type into context correctly. #73074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for swiftlang#72484 didn't properly handle the case of a "generic" context where all the type parameters had concrete assignments. In this situation, F.mapTypeIntoContext does not work because the function has no generic environment. Fixes rdar://126085573
|
@swift-ci Please test |
hborla
approved these changes
Apr 17, 2024
|
Looks like "original PR" field in the description is wrong, it links to an unrelated PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: The fix for #72484 didn't properly handle the case of a "generic" context where all the type parameters had concrete assignments. In this situation, F.mapTypeIntoContext does not work because the function has no generic environment.
Scope: Conversions of actor-instance-isolated functions to
@isolated(any)type, which happens on all of the basic paths for task creation.Issue: rdar://126085573
Original PR: #73031
Risk: Low. Highly localized fix that is well-tested for previously-working code paths.
Testing: New regression test
Reviewer: (tbd)